Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/772#discussion_r40093205
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto ---
    @@ -262,6 +262,18 @@ message PartitionIdentifierProto {
       optional string partitionName = 3;
     }
     
    +message PartitionsByAlgebraProto {
    +  required string databaseName = 1;
    +  required string tableName = 2;
    +  required string algebra = 3; /** json object which contains algebra 
expressions */
    +}
    +
    +message PartitionsByFilterProto {
    +  required string databaseName = 1;
    +  required string tableName = 2;
    +  required string filter = 3; /** filter condition, for example col1 = 
'TAJO' and col2 = 100. */
    --- End diff --
    
    Please use ```//``` instead of ```/**/```. 
    In addition, which format is used for filter serialization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to