[ 
https://issues.apache.org/jira/browse/TAJO-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958150#comment-14958150
 ] 

ASF GitHub Bot commented on TAJO-1926:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/824#discussion_r42075095
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
 ---
    @@ -174,18 +173,17 @@ private void addPartition(String partition) throws 
IOException {
     
           PartitionKeyProto.Builder keyBuilder = 
PartitionKeyProto.newBuilder();
           keyBuilder.setColumnName(split[0]);
    -      // Partition path have been escaped to avoid URISyntaxException. But 
partition value of partition keys table
    -      // need to contain unescaped value for comparing filter conditions 
in select statement.
    -      keyBuilder.setPartitionValue(StringUtils.unescapePathName(split[1]));
    +      keyBuilder.setPartitionValue(split[1]);
     
           builder.addPartitionKeys(keyBuilder.build());
         }
     
         if (this.plan.getUri() == null) {
    -      // In CTAS, the uri would be null. So, it get the uri from staging 
directory.
    -      int endIndex = 
storeTablePath.toString().indexOf(FileTablespace.TMP_STAGING_DIR_PREFIX);
    --- End diff --
    
    This code must be added.


> Disable partition pruning using catalog temporarily.
> ----------------------------------------------------
>
>                 Key: TAJO-1926
>                 URL: https://issues.apache.org/jira/browse/TAJO-1926
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog, Physical Operator, Planner/Optimizer
>    Affects Versions: 0.11.0, 0.12.0
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>            Priority: Critical
>             Fix For: 0.11.0
>
>
> We disabled alter table add partition temporarily at TAJO-1887. But when 
> adding partitions with dfs command for external partitioned table, there is 
> no way to add partition to catalog. As a result, users can't scan their 
> partitions which are added manually to file system. So, we need to disable 
> partition pruning using catalog until implement TAJO-1891.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to