[ 
https://issues.apache.org/jira/browse/TAJO-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958806#comment-14958806
 ] 

ASF GitHub Bot commented on TAJO-1926:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/824#discussion_r42116216
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/planner/TestPartitionedTableRewriter.java
 ---
    @@ -0,0 +1,108 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.engine.planner;
    +
    +import org.apache.hadoop.fs.Path;
    +import org.apache.tajo.LocalTajoTestingUtility;
    +import org.apache.tajo.OverridableConf;
    +import org.apache.tajo.QueryTestCaseBase;
    +import org.apache.tajo.algebra.Expr;
    +import org.apache.tajo.catalog.CatalogUtil;
    +import org.apache.tajo.catalog.TableDesc;
    +import org.apache.tajo.engine.query.QueryContext;
    +import org.apache.tajo.plan.LogicalPlan;
    +import org.apache.tajo.plan.logical.*;
    +import org.apache.tajo.plan.rewrite.rules.PartitionedTableRewriter;
    +import org.apache.tajo.util.CommonTestingUtil;
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.assertTrue;
    +
    +public class TestPartitionedTableRewriter extends QueryTestCaseBase {
    --- End diff --
    
    I cannot understand what you mean. I didn't make a directory of empty 
string.
    Anyway, this is the case when the partition directory doesn't contain any 
data file. So this is not a problem.
    After adding a data file, everything works well.


> Disable partition pruning using catalog temporarily.
> ----------------------------------------------------
>
>                 Key: TAJO-1926
>                 URL: https://issues.apache.org/jira/browse/TAJO-1926
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog, Physical Operator, Planner/Optimizer
>    Affects Versions: 0.11.0, 0.12.0
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>            Priority: Critical
>             Fix For: 0.11.0
>
>
> We disabled alter table add partition temporarily at TAJO-1887. But when 
> adding partitions with dfs command for external partitioned table, there is 
> no way to add partition to catalog. As a result, users can't scan their 
> partitions which are added manually to file system. So, we need to disable 
> partition pruning using catalog until implement TAJO-1891.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to