Github user dkhwangbo commented on a diff in the pull request:
https://github.com/apache/tajo/pull/817#discussion_r43708266
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
---
@@ -393,18 +393,18 @@ public static double getCost(JoinEdge joinEdge) {
break;
}
// cost = estimated input size * filter factor * (output tuple width
/ input tuple width)
- cost = getCost(joinEdge.getLeftVertex()) *
- getCost(joinEdge.getRightVertex()) * factor;
+ cost = getCostWithVertex(joinEdge.getLeftVertex()) *
+ getCostWithVertex(joinEdge.getRightVertex()) * factor;
} else {
// make cost bigger if cross join
- cost = Math.pow(getCost(joinEdge.getLeftVertex()) *
- getCost(joinEdge.getRightVertex()), 2);
+ cost = Math.pow(getCostWithVertex(joinEdge.getLeftVertex()) *
+ getCostWithVertex(joinEdge.getRightVertex()), 2);
}
return checkInfinity(cost * COMPUTATION_FACTOR);
}
- public static double getCost(JoinVertex joinVertex) {
+ public static double getCostWithVertex(JoinVertex joinVertex) {
--- End diff --
OK. I apply your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
