Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r47456959
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java ---
@@ -35,113 +35,113 @@
public class TaskRequestImpl implements TaskRequest {
- private TaskAttemptId id;
- private List<FragmentProto> fragments;
- private String outputTable;
- private boolean isUpdated;
- private boolean clusteredOutput;
- private PlanProto.LogicalNodeTree plan; // logical node
- private Boolean interQuery;
- private List<FetchImpl> fetches;
- private QueryContext queryContext;
- private DataChannel dataChannel;
- private Enforcer enforcer;
- private String queryMasterHostAndPort;
-
- private TaskRequestProto proto = TaskRequestProto.getDefaultInstance();
- private TaskRequestProto.Builder builder = null;
- private boolean viaProto = false;
-
- public TaskRequestImpl() {
- builder = TaskRequestProto.newBuilder();
- this.id = null;
- this.isUpdated = false;
- }
-
- public TaskRequestImpl(TaskAttemptId id, List<FragmentProto> fragments,
-
String outputTable, boolean clusteredOutput,
-
PlanProto.LogicalNodeTree plan, QueryContext queryContext,
DataChannel channel,
-
Enforcer enforcer, String queryMasterHostAndPort) {
- this();
- this.set(id, fragments, outputTable, clusteredOutput, plan,
queryContext, channel, enforcer, queryMasterHostAndPort);
- }
-
- public TaskRequestImpl(TaskRequestProto proto) {
- this.proto = proto;
- viaProto = true;
- id = null;
- isUpdated = false;
- }
-
- public void set(TaskAttemptId id, List<FragmentProto> fragments,
- String outputTable, boolean clusteredOutput,
- PlanProto.LogicalNodeTree plan, QueryContext
queryContext,
-
DataChannel dataChannel, Enforcer enforcer, String queryMasterHostAndPort) {
- this.id = id;
- this.fragments = fragments;
- this.outputTable = outputTable;
- this.clusteredOutput = clusteredOutput;
- this.plan = plan;
- this.isUpdated = true;
- this.queryContext = queryContext;
- this.queryContext = queryContext;
- this.dataChannel = dataChannel;
- this.enforcer = enforcer;
- this.queryMasterHostAndPort = queryMasterHostAndPort;
- }
+ private TaskAttemptId id;
--- End diff --
Please remove unnecessary change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
