Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r48931564
--- Diff:
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/CatalogTestingUtil.java
---
@@ -144,14 +144,14 @@ public static PartitionDesc buildPartitionDesc(String
partitionName) {
String[] partitionNames = partitionName.split("/");
List<PartitionKeyProto> partitionKeyList = new ArrayList<>();
- for(int i = 0; i < partitionNames.length; i++) {
- String [] splits = partitionNames[i].split("=");
+ for (String partitionName1 : partitionNames) {
--- End diff --
This is also valid, but it looks not a good convention
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
