[jira] [Commented] (TAJO-2110) Fix incorrect DateTime and remove hard coded tests

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247303#comment-15247303
 ] 

ASF GitHub Bot commented on TAJO-2110:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/993#discussion_r60182642
  
    --- Diff: 
tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java ---
    @@ -364,10 +364,16 @@ private Timestamp getTimestamp(Tuple tuple, TimeZone 
tz, int index) throws SQLEx
       }
     
       private Timestamp toTimestamp(TimeMeta tm, TimeZone tz) {
    +
    +    long javaTime = 
DateTimeUtil.julianTimeToJavaTime(DateTimeUtil.toJulianTimestamp(tm));
    --- End diff --
    
    Good idea! I will add a function that hiding these code


> Fix incorrect DateTime and remove hard coded tests
> --------------------------------------------------
>
>                 Key: TAJO-2110
>                 URL: https://issues.apache.org/jira/browse/TAJO-2110
>             Project: Tajo
>          Issue Type: Bug
>          Components: Data Type, Storage, Unit Test
>    Affects Versions: 0.12.0
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>            Priority: Critical
>
> Currently, Most DateTime tests are not work correctly. because timezone is 
> hardcode to the GMT for testing.
> if you run CTAS, the result data will be incorrect. we should remove the 
> hardcoded timezone in TajoTestingCluster
> Here is some examples:
> Example 1
> {noformat}
> if you run CTAS, the result data will be incorrect
> default> create table test1 (col1 TIMESTAMP);
> default> insert overwrite into test1 select '2016-04-04 00:00:00'::TIMESTAMP;
> default> select * from test1;
> col1
> -------------------------------
> 2016-04-04 00:00:00
> (1 rows, 0.057 sec, 0 B selected)
> default> create table test2 as select * from test1;
> [=========================================>] 100%  0.105 sec
> (1 rows, 0.105 sec, 20 B inserted)
> default> select * from test2;
> col1
> -------------------------------
> 2016-04-03 15:00:00
> {noformat}
> Example 2
> {noformat}
> default> select '2016-04-04 01:00:00'::TIMESTAMP - interval '1 hour';
> ?minus
> -------------------------------
> 2016-04-04 09:00:00
> (1 rows, 0.005 sec, 0 B selected)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)