[
https://issues.apache.org/jira/browse/TAJO-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247428#comment-15247428
]
ASF GitHub Bot commented on TAJO-2110:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/993#issuecomment-211822913
Hi @jinossy, thanks for work. This is a really critical bug.
Your patch looks good, but I found some issues.
* Please disable the addition and subtraction of ```date``` and ```float```
types. Even though you didn't change this part, but it should be not allowed.
* The addition and subtraction of ```time``` and ```timestamp``` should be
allowed. Please see the below.
```
default> \d test
table name: default.test
table uri: hdfs://localhost:7020/tajo/warehouse/default/test
store type: TEXT
number of rows: 1
volume: 29 B
Options:
'timezone'='Asia/Seoul'
'text.delimiter'='|'
schema:
t TIME
ts TIMESTAMP
default> select t + ts from test;
ERROR: operator does not exist: 'default.test.t (TIME) + default.test.ts
(TIMESTAMP)'
```
* The below error message looks not appropriate.
```
default> select '1990-01-01'::date + '1990-01-01 00:10:10'::timestamp;
ERROR: internal error: Cannot compare to TIMESTAMP type datum
```
* The following cases should not be allowed.
```
default> select '00:10:10'::timestamp;
?cast
-------------------------------
0002-11-30 00:10:10 BC
default> select '00:10:10'::date;
?cast
-------------------------------
0002-11-30
(1 rows, 0.003 sec, 0 B selected)
default> select '1992-01-01'::time;
?cast
-------------------------------
1992:01:01
(1 rows, 0.003 sec, 0 B selected)
```
> Fix incorrect DateTime and remove hard coded tests
> --------------------------------------------------
>
> Key: TAJO-2110
> URL: https://issues.apache.org/jira/browse/TAJO-2110
> Project: Tajo
> Issue Type: Bug
> Components: Data Type, Storage, Unit Test
> Affects Versions: 0.12.0
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Priority: Critical
>
> Currently, Most DateTime tests are not work correctly. because timezone is
> hardcode to the GMT for testing.
> if you run CTAS, the result data will be incorrect. we should remove the
> hardcoded timezone in TajoTestingCluster
> Here is some examples:
> Example 1
> {noformat}
> if you run CTAS, the result data will be incorrect
> default> create table test1 (col1 TIMESTAMP);
> default> insert overwrite into test1 select '2016-04-04 00:00:00'::TIMESTAMP;
> default> select * from test1;
> col1
> -------------------------------
> 2016-04-04 00:00:00
> (1 rows, 0.057 sec, 0 B selected)
> default> create table test2 as select * from test1;
> [=========================================>] 100% 0.105 sec
> (1 rows, 0.105 sec, 20 B inserted)
> default> select * from test2;
> col1
> -------------------------------
> 2016-04-03 15:00:00
> {noformat}
> Example 2
> {noformat}
> default> select '2016-04-04 01:00:00'::TIMESTAMP - interval '1 hour';
> ?minus
> -------------------------------
> 2016-04-04 09:00:00
> (1 rows, 0.005 sec, 0 B selected)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
