[
https://issues.apache.org/jira/browse/TAJO-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249170#comment-15249170
]
ASF GitHub Bot commented on TAJO-2110:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/993#issuecomment-212225990
@jinossy, thanks for your quick response. I agree on the need of parser
validator.
In addition to the above comments, I found another case in which the result
is not the one I expected.
Here is an example.
```
default> create table test2 (ts timestamp, d date, t time) with
('timezone'='GMT-5');
OK
default> \d test2
table name: default.test2
table uri: hdfs://localhost:7020/tajo/warehouse/default/test2
store type: TEXT
number of rows: 0
volume: 0 B
Options:
'timezone'='GMT-5'
'text.delimiter'='|'
schema:
ts TIMESTAMP
d DATE
t TIME
default> insert into test2 select '2016-05-01 02:02:33'::timestamp,
'2016-05-01':: date, '02:02:33'::time;
OK
default> \set
Invalid command \se. Try \? for help.
'SESSION_LAST_ACCESS_TIME'='1461120772913'
'CURRENT_DATABASE'='default'
'USERNAME'='jihoon'
'SESSION_ID'='351f5cb9-7dea-4277-9041-46962439622e'
'TIMEZONE'='Asia/Seoul'
'FETCH_ROWNUM'='200'
'COMPRESSED_RESULT_TRANSFER'='false'
default> select * from test2;
ts, d, t
-------------------------------
2016-05-01 02:02:33, 2016-05-01, 02:02:33
(1 rows, 0.028 sec, 0 B selected)
default> \set TIMEZONE GMT-5
default> select * from test2;
ts, d, t
-------------------------------
2016-04-30 12:02:33, 2016-05-01, 02:02:33
(1 rows, 0.014 sec, 0 B selected)
```
Even though I created the table ```test2``` with the timezone of 'GMT-5',
the result value is the inserted one only when the client timezone is 'GMT+9'.
> Fix incorrect DateTime and remove hard coded tests
> --------------------------------------------------
>
> Key: TAJO-2110
> URL: https://issues.apache.org/jira/browse/TAJO-2110
> Project: Tajo
> Issue Type: Bug
> Components: Data Type, Storage, Unit Test
> Affects Versions: 0.12.0
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Priority: Critical
>
> Currently, Most DateTime tests are not work correctly. because timezone is
> hardcode to the GMT for testing.
> if you run CTAS, the result data will be incorrect. we should remove the
> hardcoded timezone in TajoTestingCluster
> Here is some examples:
> Example 1
> {noformat}
> if you run CTAS, the result data will be incorrect
> default> create table test1 (col1 TIMESTAMP);
> default> insert overwrite into test1 select '2016-04-04 00:00:00'::TIMESTAMP;
> default> select * from test1;
> col1
> -------------------------------
> 2016-04-04 00:00:00
> (1 rows, 0.057 sec, 0 B selected)
> default> create table test2 as select * from test1;
> [=========================================>] 100% 0.105 sec
> (1 rows, 0.105 sec, 20 B inserted)
> default> select * from test2;
> col1
> -------------------------------
> 2016-04-03 15:00:00
> {noformat}
> Example 2
> {noformat}
> default> select '2016-04-04 01:00:00'::TIMESTAMP - interval '1 hour';
> ?minus
> -------------------------------
> 2016-04-04 09:00:00
> (1 rows, 0.005 sec, 0 B selected)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
