[
https://issues.apache.org/jira/browse/TAJO-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292587#comment-15292587
]
ASF GitHub Bot commented on TAJO-1968:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1028#discussion_r63984277
--- Diff: tajo-common/src/main/java/org/apache/tajo/SessionVars.java ---
@@ -31,7 +31,7 @@
// Common Suffix Naming Rules:
//
- // * LIMIT - We use the suffix 'LIMIT' if the variable is threshold.
So, if some value is greater or less than
+ // * LIMIT - We use the suffix 'LIMIT' if the variable is limit. So,
if some value is greater or less than
--- End diff --
In this context, ```threshold``` is more appropriate.
> Change 'threshold' in the name of configuration and session variables to
> 'limit'
> --------------------------------------------------------------------------------
>
> Key: TAJO-1968
> URL: https://issues.apache.org/jira/browse/TAJO-1968
> Project: Tajo
> Issue Type: Task
> Components: conf and scripts
> Reporter: Jihoon Son
> Assignee: Byunghoon Lim
> Priority: Minor
> Labels: newbie
> Fix For: 0.12.0
>
>
> See the discussion at
> https://github.com/apache/tajo/pull/848#discussion_r44101976.
> We need to make the configuration names consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
