[
https://issues.apache.org/jira/browse/TAJO-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292602#comment-15292602
]
ASF GitHub Bot commented on TAJO-1968:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/1028#issuecomment-220505013
Hi @seian, thank you for your patch.
It doesn't matter to change variable names if there are no problem for
contributors to read code.
However, documents and comments should provide clear information. So, I
left a comment about changes in documents and comments. Please share why you
changed them as well.
> Change 'threshold' in the name of configuration and session variables to
> 'limit'
> --------------------------------------------------------------------------------
>
> Key: TAJO-1968
> URL: https://issues.apache.org/jira/browse/TAJO-1968
> Project: Tajo
> Issue Type: Task
> Components: conf and scripts
> Reporter: Jihoon Son
> Assignee: Byunghoon Lim
> Priority: Minor
> Labels: newbie
> Fix For: 0.12.0
>
>
> See the discussion at
> https://github.com/apache/tajo/pull/848#discussion_r44101976.
> We need to make the configuration names consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
