[ 
https://issues.apache.org/jira/browse/TAJO-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882020#comment-13882020
 ] 

Tajo QA commented on TAJO-551:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12625204/TAJO-551.patch
  against master revision e23e78c.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 257 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-server 
tajo-core/tajo-core-backend.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/76//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/76//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/76//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/76//console

This message is automatically generated.

> Fix bug getFunction can get wrong function that have invalid parameters
> -----------------------------------------------------------------------
>
>                 Key: TAJO-551
>                 URL: https://issues.apache.org/jira/browse/TAJO-551
>             Project: Tajo
>          Issue Type: Bug
>          Components: function/udf
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>         Attachments: TAJO-551.patch
>
>
> currently, containFunction and getFunction can get a function that has 
> invalid parameter
> {noformat}
>            FunctionDesc meta = new FunctionDesc("test10", TestFunc2.class, 
> FunctionType.GENERAL,
>              CatalogUtil.newSimpleDataType(Type.INT4),
>              CatalogUtil.newSimpleDataTypeArray(Type.INT4, Type.BLOB));
>           catalog.createFunction(meta);             
> assertTrue(catalog.containFunction("test10", 
> CatalogUtil.newSimpleDataTypeArray(Type.INT4, Type.BLOB)));
> assertTrue(catalog.containFunction("test10", 
> CatalogUtil.newSimpleDataTypeArray(Type.BLOB, Type.INT4)));
> {noformat}
> when containFunction is called with same parameter types but not order is 
> same. it just returns true or function.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to