[
https://issues.apache.org/jira/browse/TAJO-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882187#comment-13882187
]
Jihoon Son commented on TAJO-551:
---------------------------------
Nice work, DaeMyung.
But I found a bug in CatalogServer.findFunction(). At Line 448, arrays should
be compared for semantic equality. Thus, it would be better to use
Arrays.equals() insteand of just equals().
> Fix bug getFunction can get wrong function that have invalid parameters
> -----------------------------------------------------------------------
>
> Key: TAJO-551
> URL: https://issues.apache.org/jira/browse/TAJO-551
> Project: Tajo
> Issue Type: Bug
> Components: function/udf
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Attachments: TAJO-551.patch
>
>
> currently, containFunction and getFunction can get a function that has
> invalid parameter
> {noformat}
> FunctionDesc meta = new FunctionDesc("test10", TestFunc2.class,
> FunctionType.GENERAL,
> CatalogUtil.newSimpleDataType(Type.INT4),
> CatalogUtil.newSimpleDataTypeArray(Type.INT4, Type.BLOB));
> catalog.createFunction(meta);
> assertTrue(catalog.containFunction("test10",
> CatalogUtil.newSimpleDataTypeArray(Type.INT4, Type.BLOB)));
> assertTrue(catalog.containFunction("test10",
> CatalogUtil.newSimpleDataTypeArray(Type.BLOB, Type.INT4)));
> {noformat}
> when containFunction is called with same parameter types but not order is
> same. it just returns true or function.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
