[
https://issues.apache.org/jira/browse/TAJO-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905654#comment-13905654
]
Tajo QA commented on TAJO-610:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629804/TAJO-610.patch
against master revision 3f6e071.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 34 new
or modified test files.
{color:red}-1 javac.{color} The patch appears to cause the build to fail.
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/144//console
This message is automatically generated.
> Refactor Column class
> ---------------------
>
> Key: TAJO-610
> URL: https://issues.apache.org/jira/browse/TAJO-610
> Project: Tajo
> Issue Type: Bug
> Components: catalog
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.8-incubating
>
> Attachments: TAJO-610.patch
>
>
> Column class has some ambiguous methods and some complex logics.
> This patch simplifies and refactors Column class as follows:
> * Rename getColumnNum() to size()
> * Remove qualifier variable from Column and ColumnProto
> * Rename getColumnName to getSimpleName
> * Move some codes for qualification and simple name to CatalogUtil and
> refactor them for common identifiers including database, table and column
> names
> * Change Column as an immutable object
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
