[
https://issues.apache.org/jira/browse/TAJO-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905696#comment-13905696
]
Tajo QA commented on TAJO-610:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629806/TAJO-610_20140220_01%3A55%3A49.patch
against master revision 3f6e071.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 35 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 181 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-catalog/tajo-catalog-common
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog
tajo-catalog/tajo-catalog-server tajo-client tajo-common
tajo-core/tajo-core-backend tajo-jdbc tajo-storage.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/145//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/145//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/145//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/145//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/145//console
This message is automatically generated.
> Refactor Column class
> ---------------------
>
> Key: TAJO-610
> URL: https://issues.apache.org/jira/browse/TAJO-610
> Project: Tajo
> Issue Type: Bug
> Components: catalog
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.8-incubating
>
> Attachments: TAJO-610.patch, TAJO-610_20140220_01:55:49.patch
>
>
> Column class has some ambiguous methods and some complex logics.
> This patch simplifies and refactors Column class as follows:
> * Rename getColumnNum() to size()
> * Remove qualifier variable from Column and ColumnProto
> * Rename getColumnName to getSimpleName
> * Move some codes for qualification and simple name to CatalogUtil and
> refactor them for common identifiers including database, table and column
> names
> * Change Column as an immutable object
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
