[
https://issues.apache.org/jira/browse/TEZ-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079914#comment-14079914
]
Siddharth Seth commented on TEZ-1341:
-------------------------------------
{code}checkState((i == currentKeyLength), "Asked for %d got %",
currentKeyLength, i);
{code}
This seems like a statement which needs fixing.
In append(Object key, Object value)
- Check on the value class has been removed. Is that intentional ? (There's a
separate jira to remove these - so don't think they should be removed here).
Are we relying on Java to intern these strings correctly. I'm not sure how much
of an overhead that is - and how well the JVM takes care of this. Alternately,
all the messages could be declared as private constants - to ensure the JVM has
nothing to do.
> Regression: IFile append() has string concats leading to memory pressure
> ------------------------------------------------------------------------
>
> Key: TEZ-1341
> URL: https://issues.apache.org/jira/browse/TEZ-1341
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Labels: performance
> Attachments: Screen Shot 2014-07-30 at 4.54.22 PM.png,
> TEZ-1341.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
