[ 
https://issues.apache.org/jira/browse/TEZ-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080342#comment-14080342
 ] 

Siddharth Seth commented on TEZ-1341:
-------------------------------------

Looks good. Could you please change the missing "d" in "%d" at line 745 (after 
applying the patch) before committing.

So, Java is handling the String efficiently ? There's no need for constants ?

> Regression: IFile append() has string concats leading to memory pressure
> ------------------------------------------------------------------------
>
>                 Key: TEZ-1341
>                 URL: https://issues.apache.org/jira/browse/TEZ-1341
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>              Labels: performance
>         Attachments: Profiler_snapshot_With_fix.png, Screen Shot 2014-07-30 
> at 4.54.22 PM.png, Screen Shot 2014-07-31 at 4.07.28 AM.png, 
> TEZ-1341.1.patch, TEZ-1341.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to