[
https://issues.apache.org/jira/browse/TEZ-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080048#comment-14080048
]
Hitesh Shah commented on TEZ-1064:
----------------------------------
Mostly looks good.
Some minor comments:
- DAGSubmittedEvent already takes dagPlan as an arg. dagName can be set from
dagPlan instead of an additional param.
- change ""utf-8" to a static final constant.
- not sure why "RecoveryProtos.SummaryEventProto toSummaryEventProto" is
needed. Take a look at VertexGroupCommitStarted.
- "System.out.println(e.getMessage());" - if this is for debugging, can it
now be removed?
- "Assert.fail("should fail on submitDAG");" - should change message to
something more clear. For example, "Expected DAG submit to fail on duplicate
dag name".
> Restore dagName Set for duplicate detection in recovered AMs.
> --------------------------------------------------------------
>
> Key: TEZ-1064
> URL: https://issues.apache.org/jira/browse/TEZ-1064
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.4.0
> Reporter: Hitesh Shah
> Assignee: Jeff Zhang
> Attachments: Tez-1064-2.patch, Tez-1064.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
