[ 
https://issues.apache.org/jira/browse/TEZ-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082589#comment-14082589
 ] 

Bikas Saha commented on TEZ-1065:
---------------------------------

The test could be placed in TezTezJobs to avoid all the mini cluster setup 
overhead. The patch is good otherwise. However, while reading the patch I 
thought some more about this and came to the conclusion that there may be a 
better approach.
We should return the vertices in topological order. Store them in DAGImpl in 
topological order and return them in the same order. This way the vertex list 
returned will make chronological sense instead of being in some random order 
added by the user. What do you think?

> DAGStatus.getVertexStatus and other vertex related API's should maintain 
> vertex order
> -------------------------------------------------------------------------------------
>
>                 Key: TEZ-1065
>                 URL: https://issues.apache.org/jira/browse/TEZ-1065
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Bikas Saha
>            Assignee: Jeff Zhang
>              Labels: newbie
>         Attachments: TEZ-1065.1.patch, Tez-1065-2.patch, Tez-1065.patch
>
>
> They should maintain the incoming vertex order. In VertexProgress e.g. lets 
> use LinkedHashMap instead of HashMap.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to