[
https://issues.apache.org/jira/browse/TEZ-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096904#comment-14096904
]
Jeff Zhang commented on TEZ-1065:
---------------------------------
[~bikassaha] I attach the patch. Changes in patch,
* sort the vertices when detecting cycles in topological order
* add unit test for this.
But I still have some concern for this patch. I add a field
topologicalVertexStack for the topological order, which looks like a little
weird. I tried to make it as method local variable, thought of 2 methods ( but
both of them still not perfect for me )
1. pass an empty stack to verify ( makes verify method looks weird )
2. sort vertices out of the detecting cycles. ( that means another time of
graph traversal )
> DAGStatus.getVertexStatus and other vertex related API's should maintain
> vertex order
> -------------------------------------------------------------------------------------
>
> Key: TEZ-1065
> URL: https://issues.apache.org/jira/browse/TEZ-1065
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Bikas Saha
> Assignee: Jeff Zhang
> Labels: newbie
> Attachments: TEZ-1065.1.patch, Tez-1065-2.patch, Tez-1065-3.patch,
> Tez-1065.patch
>
>
> They should maintain the incoming vertex order. In VertexProgress e.g. lets
> use LinkedHashMap instead of HashMap.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
