[
https://issues.apache.org/jira/browse/TEZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135917#comment-14135917
]
Bikas Saha commented on TEZ-1495:
---------------------------------
getDAGStatusViaAM()/getVertexStatusViaAM() should probably assert that the type
of realclient is RPC client.
This could be in the common base class.
{code}+ @Override
+ public String getExecutionContext() {
+ return "Executing on YARN cluster with App id " + appId;
+ }{code}
Not clear why _waitForCompletionWithStatusUpdates() needs to move up to
DAGClientImpl. When the DAG is not completed, DAGClient defers to RPCClient
that takes care of really waiting for completion. Once DAG is completed the
DAGClientImpl could simply return immediately because the DAG is complete. Am I
missing something?
Other than the last comment, this looks good to go. Some real life workloads
are probably the best way to see how this works and if changes are needed.
If the last comment needs fixing please put up another patch. Else you could
just comment on why its needed.
Please check if the patch applies to branch-0.5 and create a 0.5 patch is this
needs to be rebased with modifications. Thanks! Need both patches to commit
this. If it applies fine then 1 patch is enough.
> ATS integration for TezClient
> -----------------------------
>
> Key: TEZ-1495
> URL: https://issues.apache.org/jira/browse/TEZ-1495
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Prakash Ramachandran
> Assignee: Prakash Ramachandran
> Attachments: TEZ-1495.1.patch, TEZ-1495.2.patch, TEZ-1495.3.patch,
> TEZ-1495.4.patch, TEZ-1495.5.patch, TEZ-1495.6.patch, TEZ-1495.WIP.1.patch
>
>
> Tez client should automatically redirect to ATS when the AM is not running.
> All APIs exposed ( DAG status, counters, etc ) from the DAGClient should
> continue to work after the AM has shut down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
