[
https://issues.apache.org/jira/browse/TEZ-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242412#comment-14242412
]
Rajesh Balamohan commented on TEZ-1775:
---------------------------------------
Minor comments
- Should TezClientUtils.parseLogParams() return null when logConfig is
empty/null?
- If so, can the if-else condition in TaskSpecificLaunchCmdOption(Configuration
conf) can be made simpler to the following?
- getSpecificTasks() can be refactored to return null
{code}
if (Strings.isNullOrEmpty(tsLaunchCmdOpts) ||
specificTaskList.isEmpty() || !isValid(specificTaskList)) {
return null;
}
public TaskSpecificLaunchCmdOption(Configuration conf) {
tsLaunchCmdOpts =
conf.getTrimmed(TezConfiguration.TEZ_TASK_SPECIFIC_LAUNCH_CMD_OPTS);
this.tasksMap = getSpecificTasks(conf);
this.tsLogParams =
TezClientUtils.parseLogParams(conf.getTrimmed(TezConfiguration.TEZ_TASK_SPECIFIC_LOG_LEVEL));
}
{code}
> Simpler task / AM logger configuration
> --------------------------------------
>
> Key: TEZ-1775
> URL: https://issues.apache.org/jira/browse/TEZ-1775
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1775.1.wip.txt, TEZ-1775.2.txt
>
>
> Currently, it's fairly difficult to configure logging beyond a generic log
> level. It'll be useful to have some control over which components need to be
> logged at a level / should be avoided. The IPC layer, for example, generates
> a lot of (multi-line) noise - which isn't useful when looking for Tez logs
> only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
