[
https://issues.apache.org/jira/browse/TEZ-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243621#comment-14243621
]
Rajesh Balamohan commented on TEZ-1775:
---------------------------------------
lgtm. +1
Minor comments:
1. Would it be good to add the following in
testTaskSpecificLogOptionsWithCommandOptions?
{code}
String optionStr = options.getTaskSpecificOption("", "v", 0);
assertTrue(optionStr.equals("-Xmx128m"));
{code}
2. Patch might need to be rebased since TEZ-1696 got checked in.
> Simpler task / AM logger configuration
> --------------------------------------
>
> Key: TEZ-1775
> URL: https://issues.apache.org/jira/browse/TEZ-1775
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1775.1.wip.txt, TEZ-1775.2.txt, TEZ-1775.3.txt,
> TEZ-1775.4.txt
>
>
> Currently, it's fairly difficult to configure logging beyond a generic log
> level. It'll be useful to have some control over which components need to be
> logged at a level / should be avoided. The IPC layer, for example, generates
> a lot of (multi-line) noise - which isn't useful when looking for Tez logs
> only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)