[jira] [Comment Edited] (TEZ-1844) Shouldn't invoke system.exit in local mode when AM is failed to start

[Chen He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TEZ-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251155#comment-14251155
 ] 

Chen He edited comment on TEZ-1844 at 12/18/14 4:25 AM:
--------------------------------------------------------

Thank you for the patch, [~zjffdu]. Two nits. 
1)" dagAmThread != null" should be checked before dagAmThread.interrupt();
2)       
} catch (Throwable t) {
LOG.fatal("Error starting DAGAppMaster", t);
if (dagAppMaster != null) {
   dagAppMaster.stop();
 }
amFailException = t;

   code format issue in the patch in LocalClient.java


was (Author: airbots):
Thank you for the patch, [~zjffdu]. Two nits. 
1)" dagAmThread != null" should be checked before dagAmThread.interrupt();
2)       LOG.fatal("Error starting DAGAppMaster", t);
          if (dagAppMaster != null) {
            dagAppMaster.stop();
          }
          amFailException = t;

   code format issue in the patch in LocalClient.java

> Shouldn't invoke system.exit in local mode when AM is failed to start
> ---------------------------------------------------------------------
>
>                 Key: TEZ-1844
>                 URL: https://issues.apache.org/jira/browse/TEZ-1844
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1844-2.patch, TEZ-1844.patch
>
>
> In local mode, TezClient and Tez-AM run in the same JVM, we don't need to 
> call system.exit when AM is failed to start, throw exception should be more 
> proper. 
> {code}
>           dagAppMaster = createDAGAppMaster(applicationAttemptId, cId, 
> currentHost, nmPort, nmHttpPort,
>                   new SystemClock(),
>                   appSubmitTime, isSession, userDir.toUri().getPath());
>           clientHandler = new DAGClientHandler(dagAppMaster);
>           DAGAppMaster.initAndStartAppMaster(dagAppMaster, 
> currentUser.getShortUserName());
>           } catch (Throwable t) {
>           LOG.fatal("Error starting DAGAppMaster", t);
>           System.exit(1);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)