[
https://issues.apache.org/jira/browse/TEZ-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251621#comment-14251621
]
Jeff Zhang edited comment on TEZ-1844 at 12/18/14 1:54 PM:
-----------------------------------------------------------
bq. One aspect however needs to be checked - the staging dir is cleaned up by a
DAGAppMaster stop. Could you please verify that this is not the directory to
which local mode generates data.
[~sseth] Currently, local mode use the same directory for staging directory and
AM's working directory. I think this is for avoiding resource localization. In
the new patch, in LocalClient I create another directory for working directory,
and copy data from staging directory to this working directory to simulate the
resource localization. So that only the staging directory will been deleted
while the working directory will still been kept there.
[~airbots] Thanks for review, address the issue in the new patch.
was (Author: zjffdu):
bq. One aspect however needs to be checked - the staging dir is cleaned up by a
DAGAppMaster stop. Could you please verify that this is not the directory to
which local mode generates data.
[~sseth] Currently, local mode use the same directory for staging directory and
AM's working directory. I think this is for avoiding resource localization. In
the new patch, in LocalClient I create another directory for working directory,
and copy data from staging directory to this working directory to simulate the
resource localization. So that only the staging directory will been removed
while the working directory will still been keep there.
[~airbots] Thanks for review, address the issue in the new patch.
> Shouldn't invoke system.exit in local mode when AM is failed to start
> ---------------------------------------------------------------------
>
> Key: TEZ-1844
> URL: https://issues.apache.org/jira/browse/TEZ-1844
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-1844-2.patch, TEZ-1844-3.patch, TEZ-1844.patch
>
>
> In local mode, TezClient and Tez-AM run in the same JVM, we don't need to
> call system.exit when AM is failed to start, throw exception should be more
> proper.
> {code}
> dagAppMaster = createDAGAppMaster(applicationAttemptId, cId,
> currentHost, nmPort, nmHttpPort,
> new SystemClock(),
> appSubmitTime, isSession, userDir.toUri().getPath());
> clientHandler = new DAGClientHandler(dagAppMaster);
> DAGAppMaster.initAndStartAppMaster(dagAppMaster,
> currentUser.getShortUserName());
> } catch (Throwable t) {
> LOG.fatal("Error starting DAGAppMaster", t);
> System.exit(1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
