[
https://issues.apache.org/jira/browse/TEZ-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265218#comment-14265218
]
Siddharth Seth commented on TEZ-1892:
-------------------------------------
Comments on the patch.
hashCode - srcVertex.hashCode + destVertex.hashCode can lead to conflicts
depending on src/dest. It'll be better to let an IDE generate these methods.
equals - null check missing before checking the object being compared. Again,
would be better to use an IDE to generate, and then tune that.
> Add hashCode and equals for Vertex/VertexGroup/Edge/GroupInputEdge
> ------------------------------------------------------------------
>
> Key: TEZ-1892
> URL: https://issues.apache.org/jira/browse/TEZ-1892
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Priority: Minor
> Attachments: TEZ-1892-1.patch
>
>
> We will detect duplicated groupInputEdges using HashMap, but no hashCode and
> equals method for GroupInputEdge. Although it would still throw exception
> when duplicated GroupInputEdges is added, but it is not the correct exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
