[ 
https://issues.apache.org/jira/browse/TEZ-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274245#comment-14274245
 ] 

Siddharth Seth commented on TEZ-1917:
-------------------------------------

Thanks for posting the patch [~vasanthkumar]. Comments
- HashJoinExample - runJob does not need to parse otherArgs and validate them
- Similarly for JoinDataGen, JoinValidate, SortMergeJoinExample, 
- OrderedWordCount should implement validateArgs (move code from runJob). 
Similarly for WordCount, SimpleSessionExample, 
The rest looks good.

> Examples should extend TezExampleBase
> -------------------------------------
>
>                 Key: TEZ-1917
>                 URL: https://issues.apache.org/jira/browse/TEZ-1917
>             Project: Apache Tez
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Siddharth Seth
>            Assignee: Vasanth kumar RJ
>             Fix For: 0.7.0
>
>         Attachments: TEZ-1917.patch
>
>
> To get rid of a lot of boiler plate code from each example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to