[ 
https://issues.apache.org/jira/browse/TEZ-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275707#comment-14275707
 ] 

Siddharth Seth commented on TEZ-1917:
-------------------------------------

Thanks [~vasanthkumar]. This looks good. Requires 2 minor changes - which I'll 
make before committing the patch.
- validateArgs should not call printUsage since that's handled by 
TezExampleBase (otherwise we print usage twice)
- Marking TezExampleBase as private.

> Examples should extend TezExampleBase
> -------------------------------------
>
>                 Key: TEZ-1917
>                 URL: https://issues.apache.org/jira/browse/TEZ-1917
>             Project: Apache Tez
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Siddharth Seth
>            Assignee: Vasanth kumar RJ
>             Fix For: 0.7.0
>
>         Attachments: TEZ-1917.1.patch, TEZ-1917.2.txt, TEZ-1917.patch
>
>
> To get rid of a lot of boiler plate code from each example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to