[
https://issues.apache.org/jira/browse/TEZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313229#comment-14313229
]
Bikas Saha commented on TEZ-1914:
---------------------------------
bq. This can be handled via a VERTEX_MANAGER_INITIALIZING
Yes. That can be done but not now because recovery code depends on calling the
setup methods inline. Opened TEZ-2066 to make this change and marked it blocked
by the jira tracking the recovery change.
bq. Before the patch, everything would happen on the same thread - so there
wasn't really a problem
2 things are preventing surprises on the user code. The events for a given
VMPlugin will be executed sequentially. Those invocations are synchronized on
the vertex manager.
bq. Depending on how this is used - CallableEvent
I am expecting that events that do processing asynchronously (eg.
initializers/committers) can be moved to a common threadpool while maintaining
their event based view.
TaskImpl change fixes a race condition shown while running tests.
Updated patch address the comments. Thanks for the review!
> VertexManager logic should not run on the central dispatcher
> ------------------------------------------------------------
>
> Key: TEZ-1914
> URL: https://issues.apache.org/jira/browse/TEZ-1914
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-1914.1.patch, TEZ-1914.2.patch, TEZ-1914.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
