[
https://issues.apache.org/jira/browse/TEZ-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313774#comment-14313774
]
Siddharth Seth commented on TEZ-1233:
-------------------------------------
Minor comments for the updated patch.
- {code}LOG.warn(property + " is not standard configuration property of tez,
can not been validated");{code}
LOG at debug instead of WARN.
- getPropertySet() - VisibleForTesting annotation
- Some formatting issues - several lines are well over 100 characters.
- Not related to this patch, but could you please add a Private annotation on
the public DAGPlan createDag(Configuration tezConf, Credentials
extraCredentials, ... method in the next patch.
The rest looks good to me. +1. We can change the individual annotations later
if required.
> Allow configuration of framework parameters per vertex
> ------------------------------------------------------
>
> Key: TEZ-1233
> URL: https://issues.apache.org/jira/browse/TEZ-1233
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Jeff Zhang
> Attachments: TEZ-1233-1.patch, TEZ-1233-2.patch, TEZ-1233-3.patch
>
>
> Currently, configuration properties specific in AMConfiguration are used to
> configure tasks - e.g. memory configs, process tree, etc. These should be
> configurable at a Vertex level.
> Also, tasks end up reading these configs from the dist cache each time -
> would be simpler to send over the wire as part of the TaskSpec.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
