[
https://issues.apache.org/jira/browse/TEZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355623#comment-14355623
]
Siddharth Seth commented on TEZ-2176:
-------------------------------------
Thanks for posting the patch [~vasanthkumar]. Mostly looks good to me.
Couple of questions: is the log4j12 binding dependency required along with the
slf4j-log4j12 dependency, or can that be dropped ?
If I understand this correctly, jcl-over-slf4j provides the same interface as
commons-logging - which is why the code doesn't need to change to explicitly
use the slf4j interfaces ? The classpath for the AM / container will often
container additional jars defined by users - in which case commons-logging.jar
may show up. In this case, we shouldn't have any trouble right ? Either
jcl-over-slf4j will be used or commons-logging - but this shouldn't cause
failures ?
Hadoop exports slf4j-1.7.5. If jars from the hadoop classpath are included for
Tez containers, will this cause problems ?
Eventually, I think we should move the Loggers in each file to use slf4j
directly.
[~hitesh] - do you see any other issues with this change. I think we'll have to
mark it as incompatible since commons-logging is no longer included.
> Move all logging to slf4j
> -------------------------
>
> Key: TEZ-2176
> URL: https://issues.apache.org/jira/browse/TEZ-2176
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Vasanth kumar RJ
> Attachments: TEZ-2176.patch
>
>
> SLF4J supports a more comprehensive set of APIs - MDC, Formatted strings.
> Also drop commons-logging from the dependency set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
