[
https://issues.apache.org/jira/browse/TEZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357411#comment-14357411
]
Vasanth kumar RJ commented on TEZ-2176:
---------------------------------------
[~sseth], below given my comments
Couple of questions: is the log4j12 binding dependency required along with the
slf4j-log4j12 dependency, or can that be dropped ?
- slf4j-log4j12 has log4j dependency. So Log4j will be underlying
logging framework.
If I understand this correctly, jcl-over-slf4j provides the same interface as
commons-logging - which is why the code doesn't need to change to explicitly
use the slf4j interfaces ?
- Yes. Reference: http://www.slf4j.org/legacy.html
The classpath for the AM / container will often container additional jars
defined by users - in which case commons-logging.jar may show up. In this case,
we shouldn't have any trouble right ? Either jcl-over-slf4j will be used or
commons-logging - but this shouldn't cause failures ?
- I tried with both the jars and any one of the jar in classpath. I didn't get
any errors/failures.
Hadoop exports slf4j-1.7.5. If jars from the hadoop classpath are included for
Tez containers, will this cause problems ?
- When multiple version of slf4j-log4j are found then prints warning message
and user has to remove.
Eventually, I think we should move the Loggers in each file to use slf4j
directly.
- We have to change ~190 files for avoiding jcl-over-slf4j
> Move all logging to slf4j
> -------------------------
>
> Key: TEZ-2176
> URL: https://issues.apache.org/jira/browse/TEZ-2176
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Vasanth kumar RJ
> Attachments: TEZ-2176.patch
>
>
> SLF4J supports a more comprehensive set of APIs - MDC, Formatted strings.
> Also drop commons-logging from the dependency set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
