[
https://issues.apache.org/jira/browse/TEZ-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359821#comment-14359821
]
Jeff Zhang commented on TEZ-2193:
---------------------------------
bq. Dont see references to this new constructor?
Remove it.
bq. Messages are inconsistent
One is for 0 inclusive, another is for 0 exclusive.
* physicalInput >=0
* physicalOutput >=0
* sourceTaskIndex >=0
* numConsumer > 0
bq. Check for srcTaskIndex should happen before using it in the next method.
Right?
Right, correct it in the new patch.
bq. 0 should be a legal value because vertices can have 0 tasks.
Right, correct it in the new patch.
bq. However, it would be good to add a check in the ScatterGatherEdgeManager
to check that num destination tasks >= 0.
Add it in ScatterGatherEdgeManager.
> Check returned value from EdgeManagerPlugin before using it
> -----------------------------------------------------------
>
> Key: TEZ-2193
> URL: https://issues.apache.org/jira/browse/TEZ-2193
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2193-1.patch, TEZ-2193-2.patch, TEZ-2193-3.patch
>
>
> e.g. dag has vertices v1, v2 and shuffle edge between them, and v2 has custom
> vertex manager and -1 parallelism. In this case v1's output spec may be has
> -1 physical edge which will cause task hangs in TezChild.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
