[
https://issues.apache.org/jira/browse/TEZ-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361402#comment-14361402
]
Bikas Saha commented on TEZ-2193:
---------------------------------
Perhaps add a test similar to TestEdge#testOneToOneEdgeManager() for the
scatter gather edge change.
getPhysicalOutput/Input... methods may be called multiple times when creating
the tasks of large vertex. It would help if the Preconditions message was not
created with string + everytime (even though its going to pass almost always).
Perhaps we can use a pre-assembled string here if we don't print the actual
invalid value.
{code} + Preconditions.checkArgument(physicalOutputCount >= 0,
+ "PhysicalOutputCount should not be negative,"
+ + "physicalOutputCount=" + physicalOutputCount
+ + ", srcVertex=" + sourceVertex.getLogIdentifier()
+ + ", destVertex=" + destinationVertex.getLogIdentifier()
+ + ", EdgeManager=" + edgeManager.getClass().getName());{code}
Consumer task num can be 0 because a task in the source may not have any
consumers in this edge but may have consumers on a different edge.
{code} srcTaskIndex);
+ Preconditions.checkArgument(numConsumers > 0,
+ "ConsumerTaskNum must be positive,"
+ + "numConsumers=" + numConsumers{code}
> Check returned value from EdgeManagerPlugin before using it
> -----------------------------------------------------------
>
> Key: TEZ-2193
> URL: https://issues.apache.org/jira/browse/TEZ-2193
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2193-1.patch, TEZ-2193-2.patch, TEZ-2193-3.patch
>
>
> e.g. dag has vertices v1, v2 and shuffle edge between them, and v2 has custom
> vertex manager and -1 parallelism. In this case v1's output spec may be has
> -1 physical edge which will cause task hangs in TezChild.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
