[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391163#comment-14391163
]
Hitesh Shah commented on TEZ-2226:
----------------------------------
The patch does seem to have some inconsistencies in terms of how it handles
various cases.
It might be good if you first wrote unit tests to test the various scenarios
and verify the patch against them:
- if acls disabled, writing to timeline should continue to work
- what if there is an intermittent error i.e. within a session, domain
creation fails for 1 dag but succeeds for the next one, will we stop writing
history for all dags or just one of them?
- Likewise for the non-session case, where the same TezClient is being used
to submit multiple dags.
> Disable writing history to timeline if domain creation fails.
> -------------------------------------------------------------
>
> Key: TEZ-2226
> URL: https://issues.apache.org/jira/browse/TEZ-2226
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Chang Li
> Priority: Blocker
> Attachments: TEZ-2226.2.patch, TEZ-2226.3.patch, TEZ-2226.patch,
> TEZ-2226.wip.2.patch, TEZ-2226.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
