[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482196#comment-14482196
]
Chang Li commented on TEZ-2226:
-------------------------------
[~hitesh] thanks for pointing out the problems. I have been reading more
relevant codes and gained better understanding of this issue now. I have
changed the method to handle this issue and updated my patch. The current fix
will check acl disable and ignore timeline domain creation failure acl disable
is set. For session mode, intermittent failure of dag submission will not
affect following dag submissions, we only disable writing history for dags that
fail to create domain. The same principle applies to non-session case if the
same tezclient is used to submit multiple dags.
However I am having some difficulties to write unit tests to test those
scenarios. I am having troubles to introduce putdomain failure in test. I was
trying to follow the existing test in TestATSHistoryWithACLs, but if I test
from tezclient I am not able to mock the timelineClient in
HistoryAclPolicyManager to throw exception.
> Disable writing history to timeline if domain creation fails.
> -------------------------------------------------------------
>
> Key: TEZ-2226
> URL: https://issues.apache.org/jira/browse/TEZ-2226
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Chang Li
> Priority: Blocker
> Attachments: TEZ-2226.2.patch, TEZ-2226.3.patch, TEZ-2226.4.patch,
> TEZ-2226.patch, TEZ-2226.wip.2.patch, TEZ-2226.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
