[
https://issues.apache.org/jira/browse/TEZ-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491860#comment-14491860
]
Bikas Saha commented on TEZ-2225:
---------------------------------
If done correctly, sl4j takes care of the perf aspects - please see
http://www.slf4j.org/faq.html#logging_performance
However not all cases are covered by the sl4j technique - e.g. when some method
is being called to generate the argument to the log statement. [~vasanthkumar]
Could you please take a look at
http://stackoverflow.com/questions/8444266/even-with-slf4j-should-you-guard-your-logging
and verify that we are making the correct changes when the logger argument is
invoking a method instead of accessing a local variable? Committing the patch
would be easy once you have confirmed that. Thanks. Trying to trigger another
build to verify findbugs.
> Remove instances of LOG.isDebugEnabled
> --------------------------------------
>
> Key: TEZ-2225
> URL: https://issues.apache.org/jira/browse/TEZ-2225
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Vasanth kumar RJ
> Assignee: Vasanth kumar RJ
> Priority: Minor
> Labels: performance
> Attachments: TEZ-2225.1.patch, TEZ-2225.2.patch, TEZ-2225.3.patch
>
>
> Remove LOG.isDebugEnabled() and use parameterized debug logging
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
