[ 
https://issues.apache.org/jira/browse/TEZ-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492754#comment-14492754
 ] 

Siddharth Seth commented on TEZ-2225:
-------------------------------------

What slf4j seems to provide is the capability to avoid parameter replacement in 
the strings.
Are the strings interned ? or are they created and discarded if debug logging 
isn't enabled (again, specifically in loops). Why not just leave the 
isDebugEnabled checks in place.

> Remove instances of LOG.isDebugEnabled
> --------------------------------------
>
>                 Key: TEZ-2225
>                 URL: https://issues.apache.org/jira/browse/TEZ-2225
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Vasanth kumar RJ
>            Assignee: Vasanth kumar RJ
>            Priority: Minor
>              Labels: performance
>         Attachments: TEZ-2225.1.patch, TEZ-2225.2.patch, TEZ-2225.3.patch
>
>
> Remove LOG.isDebugEnabled() and use parameterized debug logging



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to