[ 
https://issues.apache.org/jira/browse/TEZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503686#comment-14503686
 ] 

Hitesh Shah commented on TEZ-2212:
----------------------------------

Comments: 

{code}
case DAG_SUBMITTED:
              // Inform sub-components that a new DAG has been submitted.
              taskSchedulerEventHandler.dagSubmitted();
              containerLauncher.dagSubmitted();
              taskAttemptListener.dagSubmitted();
              nodes.dagSubmitted();
              containers.dagSubmitted();
{code}

Any reason why this is not handled directly in the DAGAppMaster::submitDAG 
handler? Also, does it need to have a dag id? Maybe we can remove the 
submission handling for now, until it gets implemented as everything should 
just work on an on-demand basis whenever any component is asked to do something 
for a dag that wasn't seen before? Needing any pre-setup steps might be brittle.

+1 if the dag submissions bits are removed for now ( pending pre-commit for the 
modified patch )








 





> Notify components on DAG completion
> -----------------------------------
>
>                 Key: TEZ-2212
>                 URL: https://issues.apache.org/jira/browse/TEZ-2212
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-2212.1.txt, TEZ-2212.2.txt, TEZ-2212.3.txt
>
>
> Various components, especially the ones that are made pluggable by TEZ-2003, 
> should be informed about DAG completion, so that they can perform required 
> cleanup - ContainerLauncher, TaskAttemptListener, Scheduler (already 
> informed). In addition ID caches etc should be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to