[
https://issues.apache.org/jira/browse/TEZ-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503937#comment-14503937
]
Hitesh Shah commented on TEZ-2212:
----------------------------------
Given that this is internal for now, I think this should be ok.
2 minor nits:
- Change dag submitted to a slightly different event name to distinguish
that this is dag notification for a new dag submission. Becomes a bit confusing
to read that the DagAppMaster is receiving submission and completion events and
sending mirror events back to itself. Dag cleanup is clear but submission is
not.
For dag submission:
{code}
722 case DAG_SUBMITTED:
723 // Inform sub-components that a new DAG has been submitted.
724 taskSchedulerEventHandler.dagSubmitted();
725 containerLauncher.dagSubmitted();
726 taskAttemptListener.dagSubmitted();
727 nodes.dagSubmitted();
728 containers.dagSubmitted();
{code}
- lets keep the list of components invoked very restricted. For example,
nodes and containers probably do not need the notification?
> Notify components on DAG completion
> -----------------------------------
>
> Key: TEZ-2212
> URL: https://issues.apache.org/jira/browse/TEZ-2212
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2212.1.txt, TEZ-2212.2.txt, TEZ-2212.3.txt
>
>
> Various components, especially the ones that are made pluggable by TEZ-2003,
> should be informed about DAG completion, so that they can perform required
> cleanup - ContainerLauncher, TaskAttemptListener, Scheduler (already
> informed). In addition ID caches etc should be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
