[
https://issues.apache.org/jira/browse/TEZ-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516643#comment-14516643
]
Jeff Zhang commented on TEZ-1897:
---------------------------------
Comments:
* Rename registerAndCreateDispatcher to registerAndCreateConcurrentDispatcher ?
Rename registerWithExistingDispatcher to
registerWithExistingConcurrentDispatcher ?
* Javadoc for AsyncDispatcherConcurrent is the same as AsyncDispatcher
* No concurentDispatcher checking in registerAndCreateDispatcher(Class<?
extends Enum> eventType,
EventHandler handler, String dispatcherName)
* Precondition numThreads should be at least 2 ? I think 1 is the same as
AysnDispatcher
{code}
public AsyncDispatcherConcurrent registerAndCreateDispatcher(Class<? extends
Enum> eventType,
EventHandler handler, String dispatcherName, int numThreads)
{code}
* TaskAttemptImpl.java
Some places still use getTask().getVertex(), can change to getVertex directly.
> Create a concurrent version of AsyncDispatcher
> ----------------------------------------------
>
> Key: TEZ-1897
> URL: https://issues.apache.org/jira/browse/TEZ-1897
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-1897.1.patch, TEZ-1897.2.patch, TEZ-1897.3.patch,
> TEZ-1897.4.patch, TEZ-1897.5.patch
>
>
> Currently, it processes events on a single thread. For events that can be
> executed in parallel, e.g. vertex manager events, allowing higher concurrency
> may be beneficial.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
