[
https://issues.apache.org/jira/browse/TEZ-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524433#comment-14524433
]
Rajesh Balamohan commented on TEZ-2392:
---------------------------------------
>> Why is the hasCompletedProcessing check being done after calling
>> "recordReader.next()" ? Shouldn't be called before?
Wanted to keep the regular path unaffected with this change (without branches).
>> From a thread safety point of view, is "completedProcessing" protected
>> properly?
Thread safety was not guaranteed for KeyValueReader/KeyValuesReader. For e.g,
OrderedGroupedKeyValuesReader internally makes use of ValuesIterator which does
not guarantee thread safety.
> Have all readers throw an Exception on incorrect next() usage
> -------------------------------------------------------------
>
> Key: TEZ-2392
> URL: https://issues.apache.org/jira/browse/TEZ-2392
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Rajesh Balamohan
> Priority: Critical
> Attachments: TEZ-2392.1.patch, TEZ-2392.2.patch
>
>
> Follow up from TEZ-2348.
> Marking as critical since this is a behaviour change, and we should get it in
> early.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
