[
https://issues.apache.org/jira/browse/TEZ-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527538#comment-14527538
]
Siddharth Seth commented on TEZ-2392:
-------------------------------------
Patch looks good to me - ValuesIterator has the check in the main path, but I'm
not sure that can be avoided. +1
In case of the MRReaders, the check being after "recordReader.next" leaves this
open to an exception from user code. Should just document this (in
MRInput.getReader()) - An exception will be thrown if next() is invoked after
false, either from the framework or from the underlying InputFormat.
> Have all readers throw an Exception on incorrect next() usage
> -------------------------------------------------------------
>
> Key: TEZ-2392
> URL: https://issues.apache.org/jira/browse/TEZ-2392
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Rajesh Balamohan
> Priority: Critical
> Attachments: TEZ-2392.1.patch, TEZ-2392.2.patch
>
>
> Follow up from TEZ-2348.
> Marking as critical since this is a behaviour change, and we should get it in
> early.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
