[ 
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528839#comment-14528839
 ] 

Rohini Palaniswamy commented on TEZ-2221:
-----------------------------------------

bq. Unless there is a technical reason to not support v1,v2 in multiple vertex 
groups simultaneously, we should support it.
  +1 for this. If there was no concrete reason for doing it, lets please revert 
it. To be clear, I am only asking to revert duplicate groups with different 
group names. It is good to disallow groups with same group names as the name is 
the identifier and should be unique.

> VertexGroup name should be unqiue
> ---------------------------------
>
>                 Key: TEZ-2221
>                 URL: https://issues.apache.org/jira/browse/TEZ-2221
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.7.0, 0.5.4, 0.6.1
>
>         Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch, TEZ-2221-3.patch, 
> TEZ-2221-4.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex 
> group name to identify the vertex group commit, the same name of vertex group 
> will conflict. While in the current equals & hashCode of VertexGroup, vertex 
> group name and members name are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to