[
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527869#comment-14527869
]
Jeff Zhang commented on TEZ-2221:
---------------------------------
I think this is must to have to disallow
{code}
dag.createVertexGroup("group_1", v1,v2);
dag.createVertexGroup("group_1", v2,v3);
{code}
and this is nice to have to disallow for avoiding any conflict between the 2
vertex group with same members. Although currently there's no conflicts,
VertexGroup#addDataSink is a potential one if adding same output to the 2
vertex group with same members, but the conflict will be detected by
Vertex#addAdditionalDataSink)
{code}
dag.createVertexGroup("group_1", v1,v2);
dag.createVertexGroup("group_2", v1,v2);
{code}
Since case 1 (must to have) impact the pig and pig don't use case 2, why not
keep this patch ?
> VertexGroup name should be unqiue
> ---------------------------------
>
> Key: TEZ-2221
> URL: https://issues.apache.org/jira/browse/TEZ-2221
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Fix For: 0.7.0, 0.5.4, 0.6.1
>
> Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch, TEZ-2221-3.patch,
> TEZ-2221-4.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex
> group name to identify the vertex group commit, the same name of vertex group
> will conflict. While in the current equals & hashCode of VertexGroup, vertex
> group name and members name are used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
