[ 
https://issues.apache.org/jira/browse/TEZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598821#comment-14598821
 ] 

Jeff Zhang commented on TEZ-2572:
---------------------------------

I think this is an internal risk on VertexManager not on VertexManagerPlugins. 
We only expose the api of VertexManagerPluginContextImpl#addRootInputEvent to 
user but don't expose any api of sending RootInputDataInformationEvents.
We can't control when and how many times user will call 
VertexManagerPluginContextImpl#addRootInputEvent. But we have control on when 
to send the RootInputDataInformationEvents. Currently we do it in callback of 
onRootVertexInitialized. So that means on each onRootVertexInitialized call, we 
will send RootInputDataInformationEvents back to Vertex in the callback. But 
the RootInputDataInformationEvents maybe empty if user didn't call 
VertexManagerPluginContextImpl#addRootInputEvent. Anyway, we do have risk if in 
the future we send RootInputDataInformationEvents in other places


> VertexManagerPlugins should be able to send RootInformationEvents outside of 
> the onRootVertexInitialized inocation
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-2572
>                 URL: https://issues.apache.org/jira/browse/TEZ-2572
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.4
>            Reporter: Siddharth Seth
>
> https://issues.apache.org/jira/browse/TEZ-2568?focusedCommentId=14598778&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14598778



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to