[
https://issues.apache.org/jira/browse/TEZ-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605268#comment-14605268
]
TezQA commented on TEZ-2579:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12742469/TEZ-2579-1.patch
against master revision 1421f59.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.app.dag.impl.TestVertexImpl
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/860//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/860//console
This message is automatically generated.
> Incorrect comparison of TaskAttemptId
> -------------------------------------
>
> Key: TEZ-2579
> URL: https://issues.apache.org/jira/browse/TEZ-2579
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2579-1.patch
>
>
> TaskImpl#AttemptSucceededTransition
> {code}
> // issue kill to all other attempts
> for (TaskAttempt attempt : task.attempts.values()) {
> if (attempt.getID() != task.successfulAttempt && // should use
> !equals
> !attempt.isFinished()) { // but it won't affect the state
> machine transition, because the successful task attempt should already
> complete.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
