[
https://issues.apache.org/jira/browse/TEZ-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606644#comment-14606644
]
Bikas Saha commented on TEZ-2579:
---------------------------------
Sure. But the logic of the transition is explicit with the current code. Its
clear, that a successful attempt should not be killed (whether finished or
not). So any modification going forward know what the semantics are. Hence, my
suggestion to fix the potential bug (.equals) without changing semantics.
> Incorrect comparison of TaskAttemptId
> -------------------------------------
>
> Key: TEZ-2579
> URL: https://issues.apache.org/jira/browse/TEZ-2579
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2579-1.patch
>
>
> TaskImpl#AttemptSucceededTransition
> {code}
> // issue kill to all other attempts
> for (TaskAttempt attempt : task.attempts.values()) {
> if (attempt.getID() != task.successfulAttempt && // should use
> !equals
> !attempt.isFinished()) { // but it won't affect the state
> machine transition, because the successful task attempt should already
> complete.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
