[
https://issues.apache.org/jira/browse/TEZ-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680691#comment-14680691
]
Siddharth Seth commented on TEZ-2678:
-------------------------------------
>From [~zjffdu] review on TEZ-2004.
TaskCommunicator.java Rename unregisterRunningTaskAttempt to
registerTaskAttemptEnd (make it more consistent)
Post merge / just before merge: Rename ContainerLauncherImpl to
TezContainerLauncherImpl ? Make all the default implementation with prefix Tez.
Typo DagTypeConverters.convertServicePluginDescriptoToProto -->
DagTypeConverters.convertServicePluginDescriptorToProto (miss "r")
Verify VertexExecutionContext matches against the ServicePluginDescriptor setup
for the TezClient
TaskAttempt#scheduleTime may need to put into history event
TaskAttemptStartedEvent to be used by Tez-UI
> Fix comments from reviews - part 1
> ----------------------------------
>
> Key: TEZ-2678
> URL: https://issues.apache.org/jira/browse/TEZ-2678
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: TEZ-2003
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
>
> Typos in API - Curretn, localicty, others
> Add diagnostic string wherever ContainerEndReason is used.
> TODO in ContainerLauncherContext - TEZ-2676
> TaskEndReason lossy compared to YARN.
> Cache the context in DAGImpl.getDefaultExecutionContext
> TaskAttempt. TA_KILLED moves to KILL_IN_PROGRESS instead of KILLED
> TaskAttempt - add scheduleTime to history event
> Exception propagation in ContainerLauncherRouter
> AMNodeTracker calls super("AMNodeMap");
> ContainerLauncherOperationBase - token abstraction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
