[
https://issues.apache.org/jira/browse/TEZ-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680725#comment-14680725
]
Siddharth Seth commented on TEZ-2678:
-------------------------------------
Verify abortTask/cleanup are used correctly in TezTaskRunner
why would a task call canCommit while shutting down? Shouldn’t we throw an
exception anyway as it is not meant to be called during shutdown?
Add docs to joinValidate explaining extensions are for private use.
TaskCommunicatorContextImpl: Shouldn’t each plugin manage its own containers?
Or at least shouldn’t this query be done based on which launcher plugin was
being used for the given container? Likewise for containerAlive(). | Try fixing
this to be specific to the communicator.
setAccessible not required during construction of plugins.
remove “*” e,g, import org.apache.tez.common.asterisk;
typos: logErrorIngored, hearbeats, getCurretnDagName
> Fix comments from reviews - part 1
> ----------------------------------
>
> Key: TEZ-2678
> URL: https://issues.apache.org/jira/browse/TEZ-2678
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: TEZ-2003
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
>
> Typos in API - Curretn, localicty, others
> Add diagnostic string wherever ContainerEndReason is used.
> TODO in ContainerLauncherContext - TEZ-2676
> TaskEndReason lossy compared to YARN.
> Cache the context in DAGImpl.getDefaultExecutionContext
> TaskAttempt. TA_KILLED moves to KILL_IN_PROGRESS instead of KILLED
> TaskAttempt - add scheduleTime to history event
> Exception propagation in ContainerLauncherRouter
> AMNodeTracker calls super("AMNodeMap");
> ContainerLauncherOperationBase - token abstraction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
